Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thorvg] Add usage and update version #34839

Merged
merged 14 commits into from
Nov 2, 2023
Merged

[thorvg] Add usage and update version #34839

merged 14 commits into from
Nov 2, 2023

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Nov 1, 2023 •
edited
Loading

Fixes #34786
Add usage and update version.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Nov 1, 2023
dg0yt
dg0yt reviewed Nov 1, 2023
View reviewed changes
ports/thorvg/portfile.cmake Outdated Show resolved Hide resolved
dg0yt
dg0yt reviewed Nov 1, 2023
View reviewed changes
ports/thorvg/portfile.cmake Outdated Show resolved Hide resolved
ports/thorvg/vcpkg.json Outdated Show resolved Hide resolved
@jimwang118 jimwang118 changed the title [thorvg] Add feature opengl [thorvg] Add usage and update version Nov 2, 2023
@jimwang118 jimwang118 marked this pull request as ready for review November 2, 2023 02:57
LilyWangLL
LilyWangLL previously approved these changes Nov 2, 2023
View reviewed changes
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines category:port-update The issue is with a library, which is requesting update new revision labels Nov 2, 2023
dg0yt
dg0yt reviewed Nov 2, 2023
View reviewed changes
ports/thorvg/windows-build-option.patch Outdated Show resolved Hide resolved
ports/thorvg/portfile.cmake Outdated Show resolved Hide resolved
@jimwang118 jimwang118 removed the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 2, 2023
@JavierMatosD JavierMatosD merged commit a0dcd70 into microsoft:master Nov 2, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@LilyWangLL LilyWangLL LilyWangLL left review comments

Assignees

@LilyWangLL LilyWangLL

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[thorvg] add CMake targets, enable GL renderer
5 participants
@jimwang118 @dg0yt @LilyWangLL @JavierMatosD @MonicaLiu0311