Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[websocketpp] fix cpp20.patch #34898

Merged
merged 1 commit into from Nov 6, 2023

Conversation

heinemml
Copy link
Contributor

@heinemml heinemml commented Nov 3, 2023

in #23669 cpp20.patch backports the patch [0] from the upstream websocketpp repo.
But it was added incomplete as it left out the part for websocketpp/roles/server_endpoint.hpp for unknown reasons.
This MR fixes this.

[0] zaphoyd/websocketpp@3197a52

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

cpp20.patch backports the patch [0] from the upstream repo but is incomplete
as it left out the part for websocketpp/roles/server_endpoint.hpp.

[0] zaphoyd/websocketpp@3197a52
@heinemml
Copy link
Contributor Author

heinemml commented Nov 3, 2023

@microsoft-github-policy-service agree

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 6, 2023
@heinemml heinemml marked this pull request as ready for review November 6, 2023 07:41
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 6, 2023
@JavierMatosD JavierMatosD merged commit 01acfdf into microsoft:master Nov 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants