Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mailio] update to 0.23.0 #34917

Merged
merged 8 commits into from
Nov 6, 2023
Merged

[mailio] update to 0.23.0 #34917

merged 8 commits into from
Nov 6, 2023

Conversation

jiayuehua
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@@ -12,6 +11,7 @@
"boost-date-time",
"boost-regex",
"boost-system",
"boost-test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add boost-test as a dependency?

Copy link
Contributor Author

@jiayuehua jiayuehua Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/karastojko/mailio/blob/8a3b92361d244dbb1af722d1ad6dcaf321907936/CMakeLists.txt#L62
find_package(Boost REQUIRED COMPONENTS system date_time regex unit_test_framework)

, I just have add patch and remove boost-test denendency.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 6, 2023
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

mailio provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(mailio CONFIG REQUIRED)
  target_link_libraries(main PRIVATE mailio)

@JavierMatosD JavierMatosD merged commit 7f2b751 into microsoft:master Nov 6, 2023
15 checks passed
@jiayuehua jiayuehua deleted the mailio branch November 6, 2023 18:41
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants