[utfcpp] Update to 4.0.2 #34933
Merged
[utfcpp] Update to 4.0.2 #34933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankXie05
added
the
category:port-update
|
Yes, I also tested it when I made this PR, and it still builds fine without any change. |
FrankXie05
approved these changes
Nov 7, 2023
Osyotr
reviewed
Nov 10, 2023
| @@ -171,7 +171,7 @@ index ca37ba1..2ce7bdd 100644 | |||
| # include <utf8.h> | |||
| #else | |||
| -# include "../contrib/utf8cpp/source/utf8.h" | |||
| +# include <utf8.h> | |||
| +# include <utf8cpp/utf8.h> | |||
There was a problem hiding this comment.
Why is this needed if include/utf8cpp is in include path?
Osyotr
reviewed
Nov 10, 2023
| target_include_directories(utf8cpp INTERFACE | ||
| "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/source>" | ||
| - $<INSTALL_INTERFACE:include> | ||
| + $<INSTALL_INTERFACE:include/utf8cpp> |
There was a problem hiding this comment.
What is the purpose of this patch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update utfcpp from 3.2.5 to 4.0.2 :
https://github.com/nemtrif/utfcpp/releases/tag/v4.0.1
https://github.com/nemtrif/utfcpp/releases/tag/v4.0.2
The CMakeLists.txt file was entirely rewritten on the version 4.0.0, and I removed the CMake options and the MinGW fix because they aren't necessary anymore. The assimp port also required some minor tweaks to be able to build with this new version.
The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.