Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo-cxx-driver] update to 3.9.0 #34994

Merged
merged 10 commits into from
Nov 17, 2023

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Nov 9, 2023

Fixes #34984
1.Update the version of mongo-cxx-driver to 3.9.0.
2.Update the versions of mongo-cxx-driver's dependencies libbson and mongo-c-driver to 1.25.1.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x86-windows
x64-windows

@jimwang118 jimwang118 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Nov 9, 2023
@jimwang118 jimwang118 marked this pull request as ready for review November 13, 2023 06:58
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These patches have different purposes and shall be left independent:
disable-dynamic-when-static.patch
fix-dependencies.patch
fix-include-directory.patch
fix-mingw.patch

I'm fine with merging the pkg-config changes into fix-dependencies.patch. It is dependencies I/O.
The include directory change is a vcpkg legacy which should better be dropped IMO.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 16, 2023
@data-queue data-queue merged commit 939eaca into microsoft:master Nov 17, 2023
15 checks passed
vicroms pushed a commit that referenced this pull request Nov 29, 2023
Probably broken by #34994

Detected in #35116

where this REGEX is expected to be output from the python script

```
CMake Error at build/cmake/LoadVersion.cmake:9 (string):
  string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:20 (LoadVersion)
```
Sungeun0318 pushed a commit to Sungeun0318/-vcpkg that referenced this pull request May 15, 2024
Probably broken by microsoft/vcpkg#34994

Detected in microsoft/vcpkg#35116

where this REGEX is expected to be output from the python script

```
CMake Error at build/cmake/LoadVersion.cmake:9 (string):
  string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:20 (LoadVersion)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongo-cxx-driver update to 3.9.0
4 participants