[CUDA] Download instead of having the user install it. #35336

Neumann-A · 2023-11-26T17:25:44Z

(Only tested with windows currently.)

Cheney-W · 2023-12-04T10:41:33Z

Tested the installation of cub:x64-windows on a machine without CUDA installed (it depends on CUDA), and cub can be successfully installed.

BillyONeal

I am concerned that by effectively creating our own CUDA distribution that isn't identical to real CUDA (with CUDA_HOME and all that stuff) that this behavior is likely to be ... 'surprising'.

Also, this copies stuff from CUDA into the installed tree; I'm not sure that's desirable.

(I'm not 'request changes' here because these are closer to 'questions' than 'this needs to change')

ports/cuda/portfile.cmake

# Conflicts: # ports/cuda-api-wrappers/vcpkg.json # versions/baseline.json # versions/c-/cuda-api-wrappers.json

BillyONeal · 2024-03-11T21:21:16Z

ports/cuda/portfile.cmake

+    set(platform linux)
+endif()
+
+set(components


Where did these lists come from?

Asking this questions 5 months after the fact is a bit hard. But probably just open https://developer.download.nvidia.com/compute/cuda/redist/ in a web browser + look at the redistrib_x.y.z.json files there and also checking conda-forge recipes.

BillyONeal · 2024-03-11T21:23:34Z

ports/cuda/portfile.cmake

+)
+
+set(util
+        #nsight_compute


My understanding is that nsight is some kind of developer gui tool so its OK that it isn't included here, but it does highlight a concern: If folks were using vcpkg with something nsight, before they were getting the matching bits for their copy of CUDA, now they might get mismatched bits. Do we have folks who actually use cuda regularly to common on the practicality of this idea?

Nobody stops you from installing the exact same version of cuda vcpkg would install. (If it even matters. From my understanding Nsight is basically a profiler like vtune to figure out bottlenecks. )

BillyONeal · 2024-03-11T21:25:03Z

ports/cuda/portfile.cmake

+
+file(READ "${cuda_redist_json}" cuda_json)
+
+file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/tools/cuda")


Unfortunately I think this implicates the tool ports thing since this is going to try to provide nvcc...

It is not trying to provide nvcc it is providing nvcc. (but you could also use the installation with clang to compile cuda)

BillyONeal · 2024-03-11T21:26:22Z

ports/cuda/portfile.cmake

+  # Don't really know why this renaming is required. 
+  file(RENAME "${CURRENT_PACKAGES_DIR}/tools/cuda/lib" "${CURRENT_PACKAGES_DIR}/tools/cuda/lib64")


In general lib vs. lib64 depends on one's distro...

tuned to what nvcc expects.

BillyONeal · 2024-03-11T21:27:13Z

ports/cuda/portfile.cmake

+  foreach(pc_file IN LISTS pc_files)
+    file(READ "${pc_file}" contents)
+    string(REGEX REPLACE "cudaroot=[^\n]+" "cudaroot=\${prefix}/tools/cuda" contents "${contents}")
+    #string(REGEX REPLACE "/targets/x86_64-linux" "" contents "${contents}")


There's a lot of commented out code in here; are you still working on this?

Hmm below 5% lines are comments in this file is considered a lot?
I probably expected this to be needed to be changed but there was no pc file consumer for cuda yet so it couldn't be properly tested.

ports/cuda/portfile.cmake

BillyONeal · 2024-03-11T21:28:29Z

ports/cuda/portfile.cmake

+set(VCPKG_POLICY_SKIP_ARCHITECTURE_CHECK enabled)
+set(VCPKG_POLICY_ONLY_RELEASE_CRT enabled)
+
+set(VCPKG_POLICY_EMPTY_INCLUDE_FOLDER enabled)


CUDA has headers so if you need this skip it seems like something is wrong? I would get this if it only made bits pointing to a separate cuda install somewhere, but it isn't doing that.

headers are not located in /include but /tools/cuda/... (whatever nvcc expects)

BillyONeal · 2024-03-11T21:40:21Z

@data-queue @ras0219-msft @vicroms @JavierMatosD and I discussed this today and we are not blocking over $CUDA_HOME not being exactly the official layout. I still need to review this overall.

I think there needs to be a description in this port describing the differences between how it installs things and how things are in a 'CUDA_HOME'.

Neumann-A · 2024-03-11T21:52:27Z

I think there needs to be a description in this port describing the differences between how it installs things and how things are in a 'CUDA_HOME'.

tools/cuda should have the same layout as CUDA_HOME since otherwise the compiler does not work. libs and dlls are also copied to (debug)?/bin (debug)?/lib for vcpkg to deploy the dlls and making it easier for cmake or other buildsystems to find the libs.

BillyONeal · 2024-03-14T00:32:15Z

tools/cuda should have the same layout as CUDA_HOME since otherwise the compiler does not work. libs and dlls are also copied to (debug)?/bin (debug)?/lib for vcpkg to deploy the dlls and making it easier for cmake or other buildsystems to find the libs.

Can you describe this in a comment in the port?

…t_cuda

Neumann-A · 2024-03-14T20:36:50Z

Can you describe this in a comment in the port?

Added a comment in 6573e17

Neumann-A · 2024-05-27T14:43:31Z

One issue here is that the license files seem to change over time.

BillyONeal · 2024-06-13T19:53:50Z

It looks like they stopped with the 'sign one's life away' to download cudnn; https://developer.download.nvidia.com/compute/cudnn/redist/cudnn/windows-x86_64/cudnn-windows-x86_64-9.2.0.82_cuda12-archive.zip looks like a normal URI now.

BillyONeal · 2024-06-14T22:11:34Z

Cracking open the installer directly seems pseudo-blessed by nvidia now

BillyONeal · 2024-06-14T22:12:17Z

(I'm just observing changes relevant to this review as I'm updating the build lab to CUDA 12.5, sorry for the spam)

# Conflicts: # ports/cudnn/FindCUDNN.cmake # ports/cudnn/portfile.cmake # ports/cudnn/vcpkg.json # versions/baseline.json # versions/c-/cudnn.json

ports/cudnn/portfile.cmake

Neumann-A added 4 commits November 26, 2023 18:24

[CUDA] Download instead of having the user install it.

40542ab

Fix manifest

6b44335

fine tuning

12b283c

remove empty dirs after tuning

584d8c0

LilyWangLL assigned Cheney-W Nov 27, 2023

Cheney-W added requires:testing Needs tests added before merging category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed requires:testing Needs tests added before merging labels Nov 27, 2023

Neumann-A added 14 commits December 2, 2023 23:30

do not install /include/cub/ since that is another port

b2a2eac

add a wrapper for cuda

24daba2

don't install cuda also into prefix

7075a48

disable debug copy

817a430

adjust installation a bit

21e55c1

fix linux installation

857d5df

Remove INCLUDE

766d775

more fine tuning

c3d4c50

more folder finetuning

5afb173

set crt linkage to static

f378317

fix post build errors

bfb1e9b

fix post build

3c841a2

Fix paths

cfe778d

v db

5cf582d

Neumann-A marked this pull request as ready for review December 4, 2023 08:01

Cheney-W previously approved these changes Dec 4, 2023

View reviewed changes

Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 4, 2023

BillyONeal reviewed Dec 5, 2023

View reviewed changes

ports/cuda/portfile.cmake Show resolved Hide resolved

BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Dec 5, 2023

Neumann-A added 2 commits March 5, 2024 10:34

Merge remote-tracking branch 'upstream/master' into get_cuda

fc09359

# Conflicts: # ports/cuda-api-wrappers/vcpkg.json # versions/baseline.json # versions/c-/cuda-api-wrappers.json

v db

fc2769c

Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 8, 2024

BillyONeal reviewed Mar 11, 2024

View reviewed changes

BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Mar 11, 2024

Neumann-A added 6 commits March 14, 2024 19:56

make CUDA_TOOLKIT_ROOT_DIR a cache variable

372f938

bit of cleanup and add more comments as requested

6573e17

v db

0ac4a8b

Merge branch 'get_cuda' of https://github.com/Neumann-A/vcpkg into ge…

86e566d

…t_cuda

Merge remote-tracking branch 'upstream/master' into get_cuda

07062ee

v db

261570a

Neumann-A added 8 commits June 19, 2024 19:26

Merge remote-tracking branch 'upstream/master' into get_cuda

88d67cc

# Conflicts: # ports/cudnn/FindCUDNN.cmake # ports/cudnn/portfile.cmake # ports/cudnn/vcpkg.json # versions/baseline.json # versions/c-/cudnn.json

Update cuda and cudnn

cb1fddf

v db

cf4fd6f

remove empty dir

9b8d604

v db

f5ef751

Merge remote-tracking branch 'upstream/master' into get_cuda

da68b24

remove problematic replace_string

d9655b3

v db

e7ac248

Neumann-A commented Jun 22, 2024

View reviewed changes

ports/cudnn/portfile.cmake Outdated Show resolved Hide resolved

Neumann-A added 2 commits June 22, 2024 23:07

Remove code from updating linux from windows

5f4ecce

v db

7accff8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CUDA] Download instead of having the user install it. #35336

[CUDA] Download instead of having the user install it. #35336

Neumann-A commented Nov 26, 2023

Cheney-W commented Dec 4, 2023

BillyONeal left a comment

BillyONeal Mar 11, 2024

Neumann-A Mar 11, 2024

BillyONeal Mar 11, 2024

Neumann-A Mar 11, 2024

BillyONeal Mar 11, 2024

Neumann-A Mar 11, 2024

BillyONeal Mar 11, 2024

Neumann-A Mar 11, 2024

BillyONeal Mar 11, 2024

Neumann-A Mar 11, 2024

BillyONeal Mar 11, 2024

Neumann-A Mar 11, 2024

BillyONeal commented Mar 11, 2024

Neumann-A commented Mar 11, 2024

BillyONeal commented Mar 14, 2024

Neumann-A commented Mar 14, 2024

Neumann-A commented May 27, 2024

BillyONeal commented Jun 13, 2024

BillyONeal commented Jun 14, 2024

BillyONeal commented Jun 14, 2024


		file(READ "${cuda_redist_json}" cuda_json)

		file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/tools/cuda")

		# Don't really know why this renaming is required.
		file(RENAME "${CURRENT_PACKAGES_DIR}/tools/cuda/lib" "${CURRENT_PACKAGES_DIR}/tools/cuda/lib64")

[CUDA] Download instead of having the user install it. #35336

Are you sure you want to change the base?

[CUDA] Download instead of having the user install it. #35336

Conversation

Neumann-A commented Nov 26, 2023

Cheney-W commented Dec 4, 2023

BillyONeal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BillyONeal commented Mar 11, 2024

Neumann-A commented Mar 11, 2024

BillyONeal commented Mar 14, 2024

Neumann-A commented Mar 14, 2024

Neumann-A commented May 27, 2024

BillyONeal commented Jun 13, 2024

BillyONeal commented Jun 14, 2024

BillyONeal commented Jun 14, 2024