Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nlohmann-json] version 3.11.3 #35385

Merged
merged 4 commits into from
Dec 1, 2023
Merged

[nlohmann-json] version 3.11.3 #35385

merged 4 commits into from
Dec 1, 2023

Conversation

kentf
Copy link
Contributor

@kentf kentf commented Nov 28, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@kentf
Copy link
Contributor Author

kentf commented Nov 28, 2023

@microsoft-github-policy-service agree

@LilyWangLL LilyWangLL self-assigned this Nov 29, 2023
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Nov 29, 2023
LilyWangLL
LilyWangLL requested changes Nov 29, 2023
View reviewed changes
ports/nlohmann-json/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

Feature diagnostics passed with following triplets:

x86-windows
x64-windows
x64-windows-static

kentf and others added 2 commits November 29, 2023 08:56
@kentf @LilyWangLL
Update ports/nlohmann-json/portfile.cmake
eb19be6 
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
@LilyWangLL
Update nlohmann-json.json
72cce0d
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Nov 30, 2023
@vicroms vicroms merged commit efe9c8a into microsoft:master Dec 1, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kentf @LilyWangLL @vicroms