Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][treehopper] Only build dynamic libraries #35435

Merged
merged 15 commits into from
Dec 5, 2023
Merged

[vcpkg baseline][treehopper] Only build dynamic libraries #35435

merged 15 commits into from
Dec 5, 2023

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented Dec 1, 2023 •
edited
Loading

Fix CI pipeline issue:
Port treehopper build failed on:

arm-neon-android
x64-android
arm64-android

Error:

- Note: treehopper only supports dynamic library linkage. Building dynamic library.
CMake Error at scripts/cmake/vcpkg_check_linkage.cmake:25 (message):
  Refusing to build unexpected dynamic library against the static CRT.

      If this is desired, please configure your triplet to directly request this configuration.

This port only supports dynamic builds, but vcpkg android triplets only provides static builds. Causes check linkage conflict and failure.
So added treehopper to ci.baseline.txt.
Related code:

vcpkg/ports/treehopper/portfile.cmake

Line 1 in e85cafa

vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY ONLY_DYNAMIC_CRT)

vcpkg/triplets/arm64-android.cmake

Line 2 in e85cafa

set(VCPKG_CRT_LINKAGE static)

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 1, 2023
@FrankXie05 FrankXie05 mentioned this pull request Dec 1, 2023
Merged
@FrankXie05 FrankXie05 added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed category:port-bug The issue is with a library, which is something the port should already support labels Dec 1, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Dec 1, 2023

Come on. You document that this is not a CI problem, so don't change ci.baseline.txt. Fix the manifest instead.

@FrankXie05
Copy link
Contributor Author

Update added to supports instead of ci.baseline.txt.

dg0yt
dg0yt reviewed Dec 1, 2023
View reviewed changes
ports/treehopper/vcpkg.json Outdated Show resolved Hide resolved
@FrankXie05 FrankXie05 marked this pull request as ready for review December 4, 2023 08:01
@FrankXie05 FrankXie05 mentioned this pull request Dec 4, 2023
Merged
7 tasks
Cheney-W
Cheney-W previously approved these changes Dec 4, 2023
View reviewed changes
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 4, 2023
@BillyONeal
Merge remote-tracking branch 'origin/master' into HEAD
7bb36e5
@BillyONeal
Also add treehopper
5557a33 
```console
PS D:\vcpkg> .\vcpkg.exe depend-info treehopper:x64-android
libusb:
vcpkg-cmake:
vcpkg-cmake-config:
treehopper: libusb, vcpkg-cmake, vcpkg-cmake-config
```
@BillyONeal
Merge remote-tracking branch 'origin/master' into HEAD
7189ee8
@BillyONeal
Copy link
Member

Depends on: #35434

BillyONeal
BillyONeal previously approved these changes Dec 4, 2023
View reviewed changes
@BillyONeal BillyONeal added the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 4, 2023
@BillyONeal BillyONeal removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 5, 2023
@BillyONeal
Merge remote-tracking branch 'origin/master' into HEAD
f9fe6af 
# Conflicts:
#	scripts/ci.baseline.txt
@BillyONeal
Copy link
Member

I am merging around build not done yet because https://dev.azure.com/vcpkg/public/_build/results?buildId=97350&view=results is building the same bits

@BillyONeal BillyONeal merged commit 85f5e13 into microsoft:master Dec 5, 2023
2 checks passed
@FrankXie05 FrankXie05 deleted the dev/Frank/ci_treehopper branch December 5, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@BillyONeal BillyONeal BillyONeal left review comments

@Cheney-W Cheney-W Cheney-W left review comments

Assignees

@Cheney-W Cheney-W

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FrankXie05 @dg0yt @BillyONeal @Cheney-W