Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrow] Add 'compute' feature to arrow #35492

Merged
merged 9 commits into from Dec 6, 2023

Conversation

aleradamantis99
Copy link
Contributor

Fixes #35490.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 5, 2023
@jimwang118
Copy link
Contributor

You should change it to "port-version": 2 in vcpkg.json.

@jimwang118 jimwang118 marked this pull request as draft December 5, 2023 05:47
@jimwang118 jimwang118 changed the title Add 'compute' feature to arrow [arrow] Add 'compute' feature to arrow Dec 5, 2023
@aleradamantis99 aleradamantis99 marked this pull request as ready for review December 5, 2023 14:32
@aleradamantis99
Copy link
Contributor Author

I changed the "version 1" to version 0, since version 0 was missing, and added version 1 as the new one. Without doing that the workflows were failing

@jimwang118
Copy link
Contributor

I changed the "version 1" to version 0, since version 0 was missing, and added version 1 as the new one. Without doing that the workflows were failing

I checked the historical update records and found that "port-version": 1 was not deleted when the version was updated last time, resulting in "port-version": 0 not appearing. You are correct in changing the version of "port-version" from 0 to 1. My colleague will submit a PR to fix this problem and wait for him After the PR is merged, the display of "port-version":0 will be correct.

@dg0yt
Copy link
Contributor

dg0yt commented Dec 6, 2023

You are correct in changing the version of "port-version" from 0 to 1. My colleague will submit a PR to fix this problem and wait for him After the PR is merged, the display of "port-version":0 will be correct.

NO!
Only move forward. Add port-version 2.

@jimwang118
Copy link
Contributor

@aleradamantis99 Please change port-version to 2.

@BillyONeal BillyONeal closed this Dec 6, 2023
@BillyONeal BillyONeal reopened this Dec 6, 2023
@BillyONeal BillyONeal merged commit 1226ef6 into microsoft:master Dec 6, 2023
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the feature!

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[arrow] Include feature 'compute' on arrow port
4 participants