Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libvpx] Use msys2 perl on win32 hosts #35593

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

HybridEidolon
Copy link
Contributor

Ensures the perl scripts for libvpx's generated headers generate correctly when the installation is under msys2.

Fixes #35592

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 self-assigned this Dec 11, 2023
@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 11, 2023
Ensures the perl scripts for libvpx's generated headers generate correctly when the installation is under msys2.
@HybridEidolon
Copy link
Contributor Author

@microsoft-github-policy-service agree

@BillyONeal
Copy link
Member

Build reason was Pull Request, using binary caching in read write mode, skipping failures.

    Directory: C:\a\1\s

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          12/18/2023  9:57 PM                empty
Clearing contents of D:\b
##[error]error: failed to remove_all_inside(D:\b) due to \\?\D:\b\gettext:  The process cannot access the file because it is being used by another process.
vcpkg clean failed
At C:\a\1\s\scripts\azure-pipelines\test-modified-ports.ps1:133 char:5
+     throw "vcpkg clean failed"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : OperationStopped: (vcpkg clean failed:String) [], RuntimeException
+ FullyQualifiedErrorId : vcpkg clean failed
##[error]PowerShell exited with code '1'.
Finishing: *** Test Modified Ports

Hmm that's a new one, doesn't seem related to this change though

@BillyONeal
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

I reset the physical mac machine

@BillyONeal
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Dec 20, 2023
@BillyONeal BillyONeal merged commit cd80671 into microsoft:master Dec 20, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks!

Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@HybridEidolon HybridEidolon deleted the patch-1 branch April 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libvpx] Build error on x86-mingw-static under msys2 32-bit
3 participants