Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bootstrap] Use official cmake configuration #35643

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[bootstrap] Use official cmake configuration #35643

merged 2 commits into from
Dec 14, 2023

Conversation

FrankXie05
Copy link
Contributor

Update vk-bootstrap version to v1.3.273.

Fix charles-lunarg/vk-bootstrap#148 (comment)
Related #32330 #22067

Use upstream's cmake configuration to completely fix the port.
The usage bas been tested successfully locally.

vk-bootstrap provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(vk-bootstrap CONFIG REQUIRED)
  target_link_libraries(main PRIVATE vk-bootstrap::vk-bootstrap vk-bootstrap::vk-bootstrap-compiler-warnings)

cc @charles-lunarg

@FrankXie05 FrankXie05 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Dec 13, 2023
@FrankXie05 FrankXie05 marked this pull request as ready for review December 13, 2023 08:42
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Dec 13, 2023
@vicroms vicroms merged commit 812e37b into microsoft:master Dec 14, 2023
15 checks passed
@FrankXie05 FrankXie05 deleted the dev/Frank/clean-bootstrap branch December 15, 2023 02:19
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@FrankXie05 @Osyotr
[bootstrap] Use official cmake configuration (microsoft#35643)
2550c0b 
* [bootstrap] Use official cmake configuration

* version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set missing cmake function IMPORTED_LOCATION
3 participants
@FrankXie05 @Adela0814 @vicroms