Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtbase] Add feature for gtk3 platform theme #35657

Merged
merged 2 commits into from Dec 19, 2023

Conversation

MB3hel
Copy link
Contributor

@MB3hel MB3hel commented Dec 13, 2023

Fixes #35594

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MB3hel
Copy link
Contributor Author

MB3hel commented Dec 13, 2023

@microsoft-github-policy-service agree

@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 14, 2023
@jimwang118
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.
Please resolve the code conflict.

@jimwang118 jimwang118 marked this pull request as draft December 14, 2023 07:50
@MB3hel MB3hel marked this pull request as ready for review December 14, 2023 17:05
@MB3hel
Copy link
Contributor Author

MB3hel commented Dec 14, 2023

Previously failed on x86-windows due to incorrect hash in versions file. Not sure why, because it was updated. Maybe related to force push / commit amend / rebase process. Not sure what happened.

Regardless, fixed now and I double checked manually this time.

@jimwang118
Copy link
Contributor

The following error occurred during local testing:

CMake Error at cmake/QtBuildInformation.cmake:508 (message):
   Feature "xcb": Forcing to "ON" breaks its condition:

       QT_FEATURE_thread AND TARGET XCB::XCB AND TEST_xcb_syslibs AND QT_FEATURE_xkbcommon_x11

   Condition values dump:

       QT_FEATURE_thread = "ON"
       TARGET XCB::XCB found
       TEST_xcb_syslibs = "FALSE"
       QT_FEATURE_xkbcommon_x11 not evaluated

config-x64-linux-out.log

@jimwang118
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@jimwang118 jimwang118 marked this pull request as draft December 15, 2023 07:54
@MB3hel
Copy link
Contributor Author

MB3hel commented Dec 15, 2023

@jimwang118 This doesn't seem to be caused by any changes in this PR. This seems to be due to missing system libraries necessary to build QT (TEST_xcb_syslibs = "FALSE" indicates such, see lines 483 and 918 of qtbase/src/gui/configure.cmake)

On an Ubuntu system, this is solved for me by running sudo apt-get install '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev as indicated by the port as required.

Without these system dependencies, this error occurs even without the changes made in this PR.

If I'm missing something here please let me know, but I don't believe this is related to my changes.

@MB3hel MB3hel marked this pull request as ready for review December 15, 2023 18:43
@jimwang118
Copy link
Contributor

@jimwang118 This doesn't seem to be caused by any changes in this PR. This seems to be due to missing system libraries necessary to build QT (TEST_xcb_syslibs = "FALSE" indicates such, see lines 483 and 918 of qtbase/src/gui/configure.cmake)

On an Ubuntu system, this is solved for me by running sudo apt-get install '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev as indicated by the port as required.

Without these system dependencies, this error occurs even without the changes made in this PR.

If I'm missing something here please let me know, but I don't believe this is related to my changes.

OK, thank you very much, I will retest this PR.

@jimwang118
Copy link
Contributor

Feature gtk3 passed with following triplets:

x64-linux

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Dec 19, 2023
@BillyONeal
Copy link
Member

@jimwang118 You can run https://github.com/microsoft/vcpkg/blob/master/scripts/azure-pipelines/linux/provision-image.sh on a Linux box to install the same stuff that our build lab installs.

@MB3hel Thanks for the feature!

@BillyONeal BillyONeal merged commit 2b0ce4c into microsoft:master Dec 19, 2023
15 checks passed
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[qtbase] Add feature for gtk3 support on Linux
3 participants