Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-api-headers/node-addon-api] update node-api-headers to 1.1.0, and update node-addon-api to 7.0.0 #35658

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

3alisaki
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@3alisaki
Copy link
Contributor Author

@microsoft-github-policy-service agree

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 14, 2023
@MonicaLiu0311 MonicaLiu0311 changed the title [node-api-headers] update to version 1.1.0, and [node-addon-api] update to version 7.0.0 [node-api-headers/node-addon-api] update node-api-headers to 1.1.0, and update node-addon-api to 7.0.0 Dec 14, 2023
@MonicaLiu0311
Copy link
Contributor

At present, the version information of your commit is inconsistent with your local one:

##[error]Found the following errors:
##[error]versions/n-/node-addon-api.json(2,): error : while parsing versions for node-addon-api from version/n-/node-addon-api.json
7.0.0 is declared with 3f82897de511d3f7cda7e4629078bf994e998914, but the local port has a different SHA 81fa7773a3a022325f43fa266ce809c1bb3ceffd.
Please update the port's version fields and then run:
vcpkg x-add-version node-addon-api --overwrite-version
git add versions
git commit -m "Update version database"
to add the new version.
##[error]versions/n-/node-api-headers.json(2,): error : while parsing versions for node-api-headers from version/n-/node-api-headers.json
1.1.0 is declared with 19988a57397b06e79323315320be67a70573dfba, but the local port has a different SHA 913a99892edcb72bcc2a479471caf0f9edb35311.
Please update the port's version fields and then run:
vcpkg x-add-version node-api-headers --overwrite-version
git add versions
git commit -m "Update version database"
to add the new version.

--overwrite-version
After the first modification, please run ./vcpkg x-add-version portName to generate the corresponding json; for subsequent modifications of the same version, please use ./vcpkg x-add-version portName --overwrite-version to update git-tree.

@3alisaki
Copy link
Contributor Author

fixed

@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

node-api-headers provides CMake targets:

    find_package(unofficial-node-api-headers CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::node-api-headers::node-api-headers)
node-addon-api provides CMake targets:

    find_package(unofficial-node-addon-api CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::node-addon-api::node-addon-api)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Dec 15, 2023
@vicroms vicroms merged commit a784648 into microsoft:master Dec 15, 2023
15 checks passed
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
…nd update node-addon-api to 7.0.0 (microsoft#35658)

* [node-api-headers] update to version 1.1.0

* [node-addon-api] update to version 7.0.0

* Update version database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants