Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drogon]: list new yaml-cpp dep under yaml feature #35715

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

justend29
Copy link
Contributor

@justend29 justend29 commented Dec 15, 2023

Version 1.9.1 of Drogon recently added to vcpkg supports parsing its configuration from YAML, and depends upon yaml-cpp by default. The exising vcpkg port did not list yaml-cpp as a dependency, causing builds to fail from missing this dependency.

These changes introduce the port feature yaml that enables YAML drogon configuration files through its build option and adds yaml-cpp as a dependency.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 18, 2023
@Cheney-W
Copy link
Contributor

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 18, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the build reset; was checking version DB :)

@BillyONeal BillyONeal merged commit 7fbe1ef into microsoft:master Dec 18, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks!

Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants