Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imgui] Add support for feature android-binding #35870

Merged
merged 1 commit into from Dec 28, 2023

Conversation

VladimirShaleev
Copy link
Contributor

Hello! The feature adds support for imgui initialization for Android ANativeWindow (NDK)

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Feature imgui[android-binding] passed with following triplets:

arm64-android
arm-neon-android
x64-android
x86-android

Now imgui can be initialized for Android NDK in the same way as for other platforms such as win32 or osx:

IMGUI_CHECKVERSION();
ImGui::CreateContext();

ImGui_ImplAndroid_Init(_app->window); // <-- initialize for ANativeWindow 
ImGui_ImplOpenGL3_Init("#version 300 es");
...

@VladimirShaleev
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Adela0814 Adela0814 self-assigned this Dec 26, 2023
@Adela0814 Adela0814 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 26, 2023
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Dec 26, 2023
@vicroms vicroms merged commit f7a371b into microsoft:master Dec 28, 2023
15 checks passed
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants