Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openCV] add vulkan support for openCV dnn #35933

Merged
merged 10 commits into from Jan 4, 2024

Conversation

sethome2
Copy link
Contributor

@sethome2 sethome2 commented Dec 30, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

I found the openCV missing Vulkan support, which is a new backend of openCV::dnn module. Now openCV supports openvion, cuda and Vulkan, so I think vulkan should be added to vcpkg package list.

I was check the function of Vulkan work normally in X64-windows.
image

Thanks for your time to check the pr.

add switch for cmake option "WITH_VULKAN"
Signed-off-by: sethome2 <39254204+sethome2@users.noreply.github.com>
fix ports/opencv/vcpkg.json ports/opencv4/vcpkg.json
@sethome2 sethome2 changed the title Sethome2 patch 1 [openCV] add vulkan support for openCV dnn Dec 30, 2023
Signed-off-by: sethome2 <39254204+sethome2@users.noreply.github.com>
@sethome2 sethome2 marked this pull request as ready for review December 30, 2023 18:48
@sethome2
Copy link
Contributor Author

sethome2 commented Dec 30, 2023

@sethome2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 2, 2024
@LilyWangLL
Copy link
Contributor

Feature opencv4[vulkan] passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL marked this pull request as draft January 2, 2024 09:33
Signed-off-by: sethome2 <39254204+sethome2@users.noreply.github.com>
to update /version/baseline/opencv/vcpkg.json
/version/baseline/opencv4/vcpkg.json
@sethome2 sethome2 marked this pull request as ready for review January 2, 2024 16:52
@sethome2
Copy link
Contributor Author

sethome2 commented Jan 2, 2024

Please modify port-version in vcpkg.json, see https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md#update-the-port-version-field-in-the-manifest-file-of-any-modified-ports.

I am so sorry that I missed checking this file. Now I modified the port-version of opencv and opencv4, and then run this command

vcpkg x-add-version opencv4
vcpkg x-add-version opencv

to update the baseline.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 3, 2024
@BillyONeal BillyONeal merged commit 80649f6 into microsoft:master Jan 4, 2024
15 checks passed
@BillyONeal
Copy link
Member

Thanks!

Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants