Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[directxsdk] Add missing d3d9 header and lib #35997

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

exposedcranium
Copy link
Contributor

The legacy directxsdk package is in a pretty bad way by the looks of things. On first glance, and for my use case, it didn't even declare d3d9.h, d3d9.lib or its associated headers/libraries from the archive, making it useless for "low-level" Direct3D work.

This is an incomplete fix-up just to add the extra missing pieces that I need for my use case. It probably needs a much more comprehensive overhaul.

Also... the package search tool declares that this supports arm64! That is obviously not the case.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@exposedcranium
Copy link
Contributor Author

@microsoft-github-policy-service agree

@exposedcranium exposedcranium changed the title directxsdk: Add missing dxd9 header and lib directxsdk: Add missing d3d9 header and lib Jan 3, 2024
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Jan 3, 2024
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 3, 2024
@JonLiu1993 JonLiu1993 changed the title directxsdk: Add missing d3d9 header and lib [directxsdk] Add missing d3d9 header and lib Jan 3, 2024
@BillyONeal BillyONeal merged commit 64e15f6 into microsoft:master Jan 3, 2024
15 checks passed
@BillyONeal
Copy link
Member

Thanks!

autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Jan 3, 2024
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants