[libflac] add wasm port support #36080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
FrankXie05
added
the
category:port-feature
FrankXie05
previously approved these changes
Jan 31, 2024
dg0yt
reviewed
Jan 31, 2024
ports/libflac/fix-wasm.patch
Outdated
Comment on lines
9
to
10
| - if(NOT MSVC) | ||
| + if(NOT MSVC AND NOT EMSCRIPTEN) |
There was a problem hiding this comment.
Does this need a patch, or can it be configured by WITH_STACK_PROTECTOR?
Is the patch sent upstream?
There was a problem hiding this comment.
I submitted a pull request for this in the flac repo: xiph/flac#664
I don't know if WITH_STACK_PROTECTOR can be configured instead.
There was a problem hiding this comment.
can this be done in the portfile instead?
set(EXTRA_OPTIONS "")
if (VCPKG_CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
set(EXTRA_OPTIONS "-DWITH_STACK_PROTECTOR=OFF")
endif()
...
vcpkg_cmake_configure(
...
OPTIONS
${EXTRA_OPTIONS}
)There was a problem hiding this comment.
@vicroms I updated my pull request to use -DWITH_STACK_PROTECTOR=OFF instead of patch.
BillyONeal
removed
the
info:reviewed
nonameentername
force-pushed
the
libflac-wasm
branch
from
253c858
to
6b6c97a
Compare
|
I'm closing this since this has been resolved in a different pull request. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.