Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][mongo-c-driver] Fix the race condition during CMake configure #36099

Merged

Conversation

LilyWangLL
Copy link
Contributor

mongo-c-driver build failed with the following errors on pipeline run Pipelines - Run 20240109.1 (azure.com):

CMake Error at build/cmake/LoadVersion.cmake:9 (string):
  string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:20 (LoadVersion)

Related: #35276, #35521, #35586

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 10, 2024
@LilyWangLL LilyWangLL marked this pull request as ready for review January 10, 2024 07:17
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2024
@Thomas1664
Copy link
Contributor

Thomas1664 commented Jan 10, 2024

This PR doesn't fix the problem. See https://github.com/microsoft/vcpkg/pull/35586/files#diff-4add37b9041ecf986958b8858c3081ff3ede0a9af46e692fb5102fe135aa3f5eR27 for the correct fix.

Disabling Python was just a cosmetic fix that had nothing to do with the root cause of the race condition.

@JavierMatosD
Copy link
Contributor

Hi @LilyWangLL, thank you for the PR! Please verify @Thomas1664 suggestion to disable parallel configure. I'll place the PR in draft while you respond.

@JavierMatosD JavierMatosD marked this pull request as draft January 11, 2024 00:57
@LilyWangLL LilyWangLL marked this pull request as ready for review January 11, 2024 10:01
@LilyWangLL
Copy link
Contributor Author

I have disabled parallel configure. Thanks for Thomas1664's suggestions.

@JavierMatosD JavierMatosD merged commit e6a1dc4 into microsoft:master Jan 11, 2024
15 checks passed
@LilyWangLL LilyWangLL deleted the dev/LilyWang/CI_baseline_mongocd branch January 18, 2024 09:34
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
…configure (microsoft#36099)

* [vcpkg baseline][mongo-c-driver] Fix the race condition during CMake configure

* update version

* update fix

* update version
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
…configure (microsoft#36099)

* [vcpkg baseline][mongo-c-driver] Fix the race condition during CMake configure

* update version

* update fix

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants