Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencv3/opencv4] Check whether TARGET libprotobuf is defined #36116

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

MonicaLiu0311
Copy link
Contributor

Fixes #36093, check if TARGET libprotobuf is defined before add_library (libprotobuf ...):

CMake Error at /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:639 (_add_library):
  _add_library cannot create imported target "libprotobuf" because another
  target with the same name already exists.
Call Stack (most recent call first):
  /opt/vcpkg/vcpkg_installed/x64-linux/share/opencv3/OpenCVModules.cmake:22 (add_library)
  /opt/vcpkg/vcpkg_installed/x64-linux/share/opencv3/OpenCVConfig.cmake:133 (include)
  /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  cmake/extra_modules.cmake:39 (find_package)
  cmake/extra_modules.cmake:162 (ov_generate_dev_package_config)
  CMakeLists.txt:142 (include)
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 11, 2024
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review January 15, 2024 07:35
@MonicaLiu0311 MonicaLiu0311 changed the title [opencv3] Check whether TARGET libprotobuf is defined [opencv3/opencv4] Check whether TARGET libprotobuf is defined Jan 15, 2024
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 16, 2024
@JavierMatosD JavierMatosD merged commit a215c6a into microsoft:master Jan 16, 2024
15 checks passed
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/fix_opencv3 branch January 17, 2024 06:34
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
…oft#36116)

* fix opencv3

* update version

* fix opencv4

* format

* update version

* add comment

* update git-tree

---------

Co-authored-by: Monica <v-liumonica@microsoft.com>
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
…oft#36116)

* fix opencv3

* update version

* fix opencv4

* format

* update version

* add comment

* update git-tree

---------

Co-authored-by: Monica <v-liumonica@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opencv3] build failure
4 participants