Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tgui] Change the cmake feature flags #36452

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

nfarid
Copy link
Contributor

@nfarid nfarid commented Jan 29, 2024

The cmake options that TGUI uses has changed:
https://github.com/texus/TGUI/blob/2aaacf812d71d0856c54df32cc3c5e375f742e59/src/Backend/CMakeLists.txt https://tgui.eu/tutorials/latest-stable/backends/

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@nfarid nfarid marked this pull request as ready for review January 29, 2024 17:49
@MonicaLiu0311 MonicaLiu0311 self-assigned this Jan 30, 2024
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Jan 30, 2024
@MonicaLiu0311
Copy link
Contributor

Features sdl2,sfml are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

The usage test passed on x64-windows (header files found):

tgui provides CMake targets:

    find_package(TGUI CONFIG REQUIRED)
    target_link_libraries(main PRIVATE TGUI::TGUI)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jan 30, 2024
@data-queue data-queue merged commit 7dc284a into microsoft:master Jan 30, 2024
16 checks passed
@nfarid nfarid deleted the tgui branch January 30, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants