[opentelemetry-cpp] remove curl as dependency to core feature #36463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
reviewed
Jan 30, 2024
JonLiu1993
reviewed
Jan 30, 2024
| @@ -2,7 +2,7 @@ | |||
| "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json", | |||
| "name": "opentelemetry-cpp", | |||
| "version-semver": "1.13.0", | |||
| "port-version": 2, | |||
| "port-version": 4, | |||
There was a problem hiding this comment.
Suggested change
| "port-version": 4, | |
| "port-version": 3, |
There was a problem hiding this comment.
I meant to merge this after after below PR which updates the same port.
JonLiu1993
reviewed
Jan 30, 2024
| @@ -11,7 +11,6 @@ | |||
| "license": "Apache-2.0", | |||
| "dependencies": [ | |||
| "abseil", | |||
| "curl", | |||
There was a problem hiding this comment.
And could you explain why you deleted this dependency?
There was a problem hiding this comment.
This dependency is not required for opentelemetry[core], and I aim to avoid building curl, as it is unnecessary and consumes build time.
JonLiu1993
added
the
category:code-cleanup
|
Depends on #36378 |
JonLiu1993
added
category:port-bug
JonLiu1993
removed
the
depends:different-pr
JonLiu1993
approved these changes
Feb 1, 2024
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
…oft#36463) * [opentelemetry-cpp] remove curl as dependency to core feature * Pick up fix from contrib repo * Update commit hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.