Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-client-cpp] fix deps #36510

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[pulsar-client-cpp] fix deps #36510

merged 1 commit into from
Feb 1, 2024

Conversation

autoantwort
Copy link
Contributor

Fixes

/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/pulsar-client-cpp/src/v3.4.2-5aee99fc11.clean/lib/SimpleLogger.h:25:10: fatal error: 'boost/format.hpp' file not found
#include <boost/format.hpp>
         ^~~~~~~~~~~~~~~~~~
1 error generated.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Feb 1, 2024
@jimwang118
Copy link
Contributor

Usage test pass with following triplets:

x86-windows
x64-windows

@data-queue data-queue merged commit 48fd773 into microsoft:master Feb 1, 2024
16 checks passed
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
@autoantwort @TomKatom
[pulsar-client-cpp] fix deps (microsoft#36510)
ffdbadc
BewareMyPower added a commit to BewareMyPower/pulsar-client-cpp that referenced this pull request Jun 11, 2024
@BewareMyPower
Upgrade vcpkg dependencies for the missed boost-format dependency
851d5d6 
### Motivation

See microsoft/vcpkg#36510

Currently the commit id of the vcpkg submodule is old. With latest
dependencies in vcpkg, it requires a `boost-format` dependency to build.

### Modifications

Upgrade the vcpkg submodule to the latest commit at the moment and add
the `boost-format` dependency to fix the build.
@BewareMyPower BewareMyPower mentioned this pull request Jun 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@autoantwort @jimwang118 @data-queue