Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portmidi] Scope alsa dependency to Linux/Android/{Free,Open}BSD #36613

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

fwcd
Copy link
Contributor

@fwcd fwcd commented Feb 6, 2024

When building for a platform like iOS portmidi (erroneously) has a dependency on ALSA. To fix this, this PR updates the platform condition from !(windows | osx) to linux | android | freebsd | openbsd (as per the description that portmidi supports BSDs). Other platforms using alsalib can be added as needed.

An alternative solution would be to exclude iOS, but my gut feeling is that declaring platforms inclusively is a more robust solution here since we avoid regressing on potentially new platforms. Thoughts welcome.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download (not applicable).
  • The "supports" clause reflects platforms that may be fixed by this new version (not applicable).
  • Any fixed CI baseline entries are removed from that file (not applicable).
  • Any patches that are no longer applied are deleted from the port's directory (not applicable).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@fwcd fwcd changed the title [portmidi] Scope alsa dependency to Linux [portmidi] Scope alsa dependency to Linux/Android/FreeBSD Feb 6, 2024
@fwcd fwcd changed the title [portmidi] Scope alsa dependency to Linux/Android/FreeBSD [portmidi] Scope alsa dependency to Linux/Android/{Free,Open}BSD Feb 6, 2024
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 7, 2024
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 7, 2024
@data-queue data-queue merged commit 783c0fe into microsoft:master Feb 7, 2024
16 checks passed
@fwcd fwcd deleted the portmidi-alsa-linux branch February 7, 2024 20:59
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
fwcd added a commit to fwcd/vcpkg that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants