[portmidi] Scope alsa dependency to Linux/Android/{Free,Open}BSD #36613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for a platform like iOS
portmidi
(erroneously) has a dependency on ALSA. To fix this, this PR updates the platform condition from!(windows | osx)
tolinux | android | freebsd | openbsd
(as per the description thatportmidi
supports BSDs). Other platforms using alsalib can be added as needed.An alternative solution would be to exclude iOS, but my gut feeling is that declaring platforms inclusively is a more robust solution here since we avoid regressing on potentially new platforms. Thoughts welcome.
./vcpkg x-add-version --all
and committing the result.