[gstreamer,libsoup,libpsl,glib-networking] enable soup plugins of gstreamer #36679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dg0yt ci for x64_windows trigger huge ports rebuild which I untouched. And I have test in centos, x64_linux should work, but ci show it failed, but I can't see why because I have not access to /mnt/vcpkg-ci/b/libsoup/package-x64-linux-dbg-err.log |
|
CI rebuilds reverse dependencies (i.e. consumers), and so it also needs to install their dependencies. Some huge artifacts cannot be cached (llvm). |
|
@dg0yt Thanks. Through logs, I found x64_linux fails because the |
data-queue
reviewed
Feb 14, 2024
dg0yt
reviewed
Feb 15, 2024
MonicaLiu0311
added
category:new-port
|
When testing G:\gs\buildtrees\gstreamer\package-x64-windows-static-dbg-out.log: |
I change portfile of gstreamer back (disable soup feature), and only add gstreamer[plugins-good] as dependence, the gstreamer[plugins-good]:x64-windows-static build failed too. The same error. Can you check without my pr, will gstreamer[plugins-good]:x64-windows-static build successfuly on your host? |
|
@MonicaLiu0311 I have test the latest master baseline 72d66da which not include my pr, the error appear as well. So I am sure the build errors are not related to my pr. Should I disabe windows-static on gstreamer in this pr? |
No need to disable it, thank you for your contribution. |
|
@MonicaLiu0311 So what should I do now? |
gstreamerFeature glib-networkingFeature Other features are tested successfully in the following triplet: libpslFeature Feature Test libsoupTest |
MonicaLiu0311
approved these changes
Feb 23, 2024
MonicaLiu0311
added
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update port gstreamer
./vcpkg x-add-version --alland committing the result.Add port libsoup,libpsl,glib-networking
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.I found the offical tutorials not work because the uridecodebin plugin can not handle https uri. Then I found that soup plugins is disabled. So I update the gstreamer to enable it. The gstreamer compiled successfuly without new port which I add. However the soup plugins will not work without libsoup. So I add the port libsoup. And it depend on libpsl and glib-networking. The glib-networking is a gio module. To make it work, we should set env GIO_MODULE_DIR to the plugins dir which glib-networking dll live in. And now I uridecodebin works properly.
By the way, how vcpkg deal with plugin dll? I put them to a plugins dir just like gstreamer. However to use them is a hard work. For a gio module, we have to set the env GIO_MODULE_DIR to the dyamic library location.