Remove password from Osx Readme for azure pipelines #36734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcristoloveanu
force-pushed
the
remove_pwd
branch
from
4a173b9
to
adbe312
Compare
dcristoloveanu
force-pushed
the
remove_pwd
branch
from
adbe312
to
3b3bf2a
Compare
BillyONeal
reviewed
Feb 14, 2024
Apply suggestions from Code Review Co-authored-by: Billy O'Neal <bion@microsoft.com>
|
I see. I took your suggestions to the review verbatim. If you want, I can polish them more, but I am guessing that is rather low ROI :-). In reply to: 1881484926 |
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the password from the OsX azure pipeline readme.md file. This password triggers credential scan errors which would have to be suppressed in projects using it within Azure, thus it is easier to remove it directly in vcpkg.