-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[folly] Delete FindLibUnwind.cmake #37020
Conversation
should also add patch that delete line 156-161 https://github.com/facebook/folly/blob/7c77eef4df2fd8ff3d37ccf190ad2a6d4b5e7e08/CMake/folly-deps.cmake#L156 |
Is there any problem with deleting |
line156 will use FindLibUnwind.cmake ,the file that deleted. |
Yes, therefore |
I see. |
The real question whether it wouldn't be enough to |
Thanks :) |
Fixes #36971
Delete
FindLibUnwind.cmake
and do not search for theLibUnwind
library.SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.Usage and feature test pass with following triplets: