Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folly] Delete FindLibUnwind.cmake #37020

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Conversation

jimwang118
Copy link
Contributor

Fixes #36971

Delete FindLibUnwind.cmake and do not search for the LibUnwind library.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage and feature test pass with following triplets:

x64-linux

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 28, 2024
@jimwang118 jimwang118 marked this pull request as ready for review February 29, 2024 02:09
LilyWangLL
LilyWangLL previously approved these changes Feb 29, 2024
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 29, 2024
@jiayuehua
Copy link
Contributor

jiayuehua commented Feb 29, 2024

@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Mar 1, 2024
@jimwang118
Copy link
Contributor Author

should also add patch that delete line 156-161 https://github.com/facebook/folly/blob/7c77eef4df2fd8ff3d37ccf190ad2a6d4b5e7e08/CMake/folly-deps.cmake#L156

Is there any problem with deleting FindLibUnwind.cmake files directly?

@jiayuehua
Copy link
Contributor

line156 will use FindLibUnwind.cmake ,the file that deleted.

@jimwang118
Copy link
Contributor Author

line156 will use FindLibUnwind.cmake ,the file that deleted.

Yes, therefore LIBUNWIND_FOUND=false will be returned, FOLLY_HAVE_LIBUNWIND:ON will not be set, and issue will not occur.
This has the same final result as deleting find_package(libunwind).

@jiayuehua
Copy link
Contributor

I see.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 1, 2024

The real question whether it wouldn't be enough to CMAKE_DISABLE_FIND_PACKAGE_LibUnwind.
But the new change matches the existing pattern in this port, so leave as is.

@LilyWangLL LilyWangLL marked this pull request as draft March 1, 2024 08:38
@jimwang118 jimwang118 marked this pull request as ready for review March 21, 2024 07:09
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 21, 2024
@BillyONeal BillyONeal merged commit d798cd7 into microsoft:master Mar 22, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[folly] Build error on x64-linux
5 participants