Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libfork] new port #37048

Merged
merged 14 commits into from
Mar 5, 2024
Merged

[libfork] new port #37048

merged 14 commits into from
Mar 5, 2024

Conversation

ConorWilliams
Copy link
Contributor

This PR adds libfork, a portable continuation stealing framework. I am the author of the package.

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@ConorWilliams
Copy link
Contributor Author

@microsoft-github-policy-service agree

@ConorWilliams ConorWilliams changed the title Libfork [libfork] add version 3.7.1 Feb 29, 2024
@ConorWilliams ConorWilliams changed the title [libfork] add version 3.7.1 [libfork] new port Feb 29, 2024
@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 1, 2024
ports/libfork/portfile.cmake Outdated Show resolved Hide resolved
ports/libfork/usage Outdated Show resolved Hide resolved
ports/libfork/vcpkg.json Show resolved Hide resolved
@jimwang118
Copy link
Contributor

Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags.

@jimwang118 jimwang118 marked this pull request as draft March 1, 2024 02:39
@jimwang118
Copy link
Contributor

May I ask where the compiled lib file is installed?

ConorWilliams and others added 2 commits March 1, 2024 14:41
Co-authored-by: jim wang <122244446+jimwang118@users.noreply.github.com>
Co-authored-by: jim wang <122244446+jimwang118@users.noreply.github.com>
@ConorWilliams
Copy link
Contributor Author

May I ask where the compiled lib file is installed?

It is a header-only lib

@ConorWilliams ConorWilliams marked this pull request as ready for review March 1, 2024 14:54
jimwang118
jimwang118 previously approved these changes Mar 4, 2024
@jimwang118
Copy link
Contributor

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 4, 2024
@ConorWilliams
Copy link
Contributor Author

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

Fantastic, are we good to merge?

@vicroms vicroms merged commit 109cb9e into microsoft:master Mar 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants