Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openimageio] Fix linking of giflib #37070

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jreichel-nvidia
Copy link
Contributor

OpenImageIO 2.5 uses now GIF targets (see
AcademySoftwareFoundation/OpenImageIO@004cbb0).

Adapt our patch accordingly (missing in #36638).

OpenImageIO 2.5 uses now GIF targets (see
AcademySoftwareFoundation/OpenImageIO@004cbb0).

Adapt our patch accordingly (missing in microsoft#36638).
@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Mar 4, 2024
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port usage test pass with following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Mar 5, 2024
@vicroms vicroms merged commit facf98f into microsoft:master Mar 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants