Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[taglib] Fix WASM build by patching out wchar_t check #37105

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

fwcd
Copy link
Contributor

@fwcd fwcd commented Mar 2, 2024

Fixes #37104

This fixes the WASM build by patching out the wchar_t size check when targeting WASM/Emscripten. From what I have read, wchar_t defaults to 32-bit when targeting Emscripten and uses 16-bit even when -fshort-wchar is set, both of which should be enough for a UTF-16 code unit, which is presumably what this check verifies.

Feel free to suggest better solutions, since this feels a bit hacky, even if it works.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Mar 4, 2024
@jimwang118
Copy link
Contributor

Usage test pass with following triplets:

x64-linux

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 4, 2024
@vicroms vicroms merged commit da3e064 into microsoft:master Mar 5, 2024
16 checks passed
@fwcd fwcd deleted the taglib-wchar-t-check branch March 5, 2024 14:59
+ endif()
endif()

check_type_size("float" SIZEOF_FLOAT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a cache variable which could have been passed as an OPTION?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[taglib] Build error on wasm32-emscripten
4 participants