Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid error when powershell isn't found in path #37188

Merged
merged 1 commit into from Mar 8, 2024
Merged

Avoid error when powershell isn't found in path #37188

merged 1 commit into from Mar 8, 2024

Conversation

abram
Copy link
Contributor

@abram abram commented Mar 6, 2024

Previously the REQUIRED flag made CMake fail with an error if powershell wasn't found on line 193. This prevented the else block on lines 197-198 from ever running.

@abram
Avoid error when powershell isn't found
ef3a55c 
Previously the REQUIRED flag made CMake fail with an error if 'powershell' wasn't found on line 193. This prevented the `else` block on lines 197-198 from ever running.
@LilyWangLL LilyWangLL self-assigned this Mar 7, 2024
@LilyWangLL LilyWangLL added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Mar 7, 2024
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 7, 2024
@vicroms vicroms merged commit 7502ccb into microsoft:master Mar 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abram @LilyWangLL @vicroms