Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chakracore] Avoid using MSVC-internal _STRINGIZE #37242

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

MonicaLiu0311
Copy link
Contributor

Microsoft's C++ standard library recently merged microsoft/STL#4405 to remove the internal _STRINGIZE macro. chakracore was using this MSVC internal macro, so avoid_msvc_internal_STRINGIZE.patch was added to adapt it to the microsoft/STL changes. Reference: chakra-core/ChakraCore#6970.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 8, 2024
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review March 8, 2024 05:44
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 8, 2024
@vicroms vicroms merged commit 4f55503 into microsoft:master Mar 8, 2024
16 checks passed
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/fix_chakracore branch March 11, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants