Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5] update to 5.15.13 #37358

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[qt5] update to 5.15.13 #37358

merged 1 commit into from
Mar 12, 2024

Conversation

carsten-grimm
Copy link
Contributor

Fixes #37357.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
  • qt5-base removed patch for CVE-2023-24607 as it was fixed upstream and Qt 5.15.13 is no longer affected.
  • qt5-webengine
    • removed patch 001-Fix-building-with-ICU-68.patch as its changes were applied upstream.
    • removed patch workaround-msvc2022-missing-include-in-chromium-ui-accessability.patch as equivalent changes were made upstream.

@carsten-grimm carsten-grimm marked this pull request as ready for review March 10, 2024 19:16
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Mar 11, 2024
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 11, 2024
@carsten-grimm
Copy link
Contributor Author

It appears that qt5-webengine is no longer build by the pipelines. I can confirm that it compiles on x64-windows.

@BillyONeal
Copy link
Member

I was really nervous about updating all those ports where no SHA changed but I sanity tested qt5-svg and it checked out OK. (Note that our CI can't detect if the SHAs aren't updated due to asset caching)

Thanks for the update!

@BillyONeal BillyONeal merged commit 55505cd into microsoft:master Mar 12, 2024
16 checks passed
@dg0yt
Copy link
Contributor

dg0yt commented Mar 12, 2024

I was really nervous about updating all those ports where no SHA changed but I sanity tested qt5-svg and it checked out OK. (Note that our CI can't detect if the SHAs aren't updated due to asset caching)

But it is all in the cone of destruction for changing qt5-base.

@carsten-grimm-at-ipolog
Copy link
Contributor

carsten-grimm-at-ipolog commented Mar 12, 2024 •
edited
Loading

I was really nervous about updating all those ports where no SHA changed but I sanity tested qt5-svg and it checked out OK. (Note that our CI can't detect if the SHAs aren't updated due to asset caching)

Thanks for the update!

Sorry, I should have mentioned that I was following the standard procedure for updating the qt5 ports that was established by @Osyotr .

@BillyONeal
Copy link
Member

But it is all in the cone of destruction for changing qt5-base.

Our CI can't detect the SHA being wrong if the SHA used is already in the asset cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qt5] update to 5.15.13
5 participants
@carsten-grimm @BillyONeal @dg0yt @carsten-grimm-at-ipolog @LilyWangLL