Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stringzilla] add stringzilla #37802

Merged
merged 12 commits into from
Mar 30, 2024
Merged

Conversation

Seedking
Copy link
Contributor

No description provided.

@Seedking
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="not have"]

@Seedking
Copy link
Contributor Author

@microsoft-github-policy-service agree

@FrankXie05 FrankXie05 self-assigned this Mar 29, 2024
@Seedking
Copy link
Contributor Author

@FrankXie05 hello sir!
I have just started learning programming and I am not quite sure how to manipulate it. Could you please guide me on how to fetch and populate a git tree?

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 29, 2024
@FrankXie05
Copy link
Contributor

@Seedking Thank you very much for following vcpkg and submitting a PR.
Just run command ./vcpkg x-add-version stringzilla --overwrite-version. :)
Note: These commands require you to have committed your changes to the ports before running them.

You can refer to the details
https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md#:~:text=ports%20at%20once.-,Note,-These%20commands%20require

@FrankXie05
Copy link
Contributor

@Seedking

Note: These commands require you to have committed your changes to the ports before running them.

Maybe what I said is not very clear. After you change the port file and run the command git commit, then run the command ./vcpkg x-add-verion stringzilla --overwrite-version.(Contains two git commits in total, just like what I did) :)

@Seedking
Copy link
Contributor Author

Sorry, I missed it ! Thank you very much for your guidance !
I won't make this mistake again next time.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Mar 29, 2024
@BillyONeal BillyONeal merged commit 3fe0b89 into microsoft:master Mar 30, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the new port :)

@Seedking Seedking deleted the add-stringzilla branch March 30, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants