Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[awlib] Add new port #37834

Merged
merged 6 commits into from
Apr 10, 2024
Merged

[awlib] Add new port #37834

merged 6 commits into from
Apr 10, 2024

Conversation

Hedede
Copy link
Contributor

@Hedede Hedede commented Mar 29, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Hedede
Copy link
Contributor Author

Hedede commented Mar 29, 2024

@microsoft-github-policy-service agree

@Hedede Hedede marked this pull request as draft March 29, 2024 19:58
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 1, 2024
@Hedede Hedede force-pushed the awlib branch 3 times, most recently from 8ba2776 to 27e6676 Compare April 1, 2024 10:13
@Hedede Hedede marked this pull request as ready for review April 1, 2024 10:20
@LilyWangLL
Copy link
Contributor

Feature hudf passed with following triplets:

x86-windows
x64-windows
x64-windows-static

Usage test passed on x64-windows.

@LilyWangLL
Copy link
Contributor

But feature graphics build failed with the following error:

CMake Error at F:/PRreview/vcpkg/downloads/tools/cmake-3.29.0-windows/cmake-3.29.0-windows-i386/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find PNG (missing: PNG_LIBRARY PNG_PNG_INCLUDE_DIR)
Call Stack (most recent call first):
  F:/PRreview/vcpkg/downloads/tools/cmake-3.29.0-windows/cmake-3.29.0-windows-i386/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  F:/PRreview/vcpkg/downloads/tools/cmake-3.29.0-windows/cmake-3.29.0-windows-i386/share/cmake-3.29/Modules/FindPNG.cmake:177 (find_package_handle_standard_args)
  F:/PRreview/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  graphics/meshes/CMakeLists.txt:1 (find_package)

@LilyWangLL LilyWangLL marked this pull request as draft April 2, 2024 07:58
@Hedede Hedede marked this pull request as ready for review April 2, 2024 09:34
@Hedede
Copy link
Contributor Author

Hedede commented Apr 2, 2024

But feature graphics build failed with the following error:

I've added missing dependencies and re-tested with a clean repo.

@LilyWangLL
Copy link
Contributor

The installation of awlib[core,graphics,hudf]:x86-windows build failed with the following error:

F:\PRreview\vcpkg\buildtrees\awlib\src\2024-04-02-75863b48ad.clean\graphics\gl\gl_api.c++(719): error C2672: 'aw::gl::get_proc': no matching overloaded function found
F:\PRreview\vcpkg\buildtrees\awlib\src\2024-04-02-75863b48ad.clean\graphics\gl\gl_api.c++(719): fatal error C1003: error count exceeds 100; stopping compilation

@LilyWangLL LilyWangLL marked this pull request as draft April 3, 2024 07:15
awlib requires latest C++ features which are not available for Android
Currently there's no support for UWP in awlib.
@Hedede Hedede marked this pull request as ready for review April 6, 2024 11:51
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

ports/awlib/portfile.cmake Outdated Show resolved Hide resolved
Hedede and others added 2 commits April 8, 2024 23:01
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 9, 2024
@JavierMatosD JavierMatosD merged commit a194ab0 into microsoft:master Apr 10, 2024
16 checks passed
@Hedede Hedede deleted the awlib branch April 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants