Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[polyhook2] Update to 2024-02-08 #37866

Merged
merged 20 commits into from
Apr 9, 2024
Merged

[polyhook2] Update to 2024-02-08 #37866

merged 20 commits into from
Apr 9, 2024

Conversation

Summpot
Copy link
Contributor

@Summpot Summpot commented Mar 30, 2024 •
edited

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Summpot Summpot marked this pull request as draft March 30, 2024 12:04
@Summpot Summpot changed the title [polyhook2] Update to 2024-03-30 [polyhook2] Update to 2024-02-08 Mar 30, 2024
@Summpot Summpot marked this pull request as ready for review March 30, 2024 12:16
dg0yt
dg0yt reviewed Mar 30, 2024
View reviewed changes
ports/polyhook2/vcpkg.json Outdated Show resolved Hide resolved
@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Apr 1, 2024
@BillyONeal
Copy link
Member

Do we still intend to block osx?

(It's OK if the answer is yes, I just want that to be explicitly understood given the questions above)

@Summpot
Copy link
Contributor Author

Summpot commented Apr 2, 2024

It seems that the library author used to support osx, but currently it doesn't compile in osx, and there should be a lack of maintenance at the moment (maybe due to the massive drop in users of x64 osx).

WangWeiLin-MV
WangWeiLin-MV requested changes Apr 3, 2024
View reviewed changes
ports/polyhook2/fix-dep.patch Show resolved Hide resolved
ports/polyhook2/vcpkg.json Show resolved Hide resolved
ports/polyhook2/vcpkg.json Show resolved Hide resolved
WangWeiLin-MV
WangWeiLin-MV approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port usage and features test pass with following triplets:

  • x64-linux
  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Apr 7, 2024
@JavierMatosD JavierMatosD merged commit 0a7d997 into microsoft:master Apr 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@dg0yt dg0yt dg0yt left review comments

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Summpot @BillyONeal @dg0yt @WangWeiLin-MV @JavierMatosD