Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wt] Update to 4.10.4 #38063

Merged
merged 9 commits into from
Apr 11, 2024
Merged

Conversation

MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 MonicaLiu0311 commented Apr 9, 2024

Update wt to 4.10.4.

1> [CMake] CMake Error at F:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package): 
1> [CMake] Could not find a package configuration file provided by "wt" with any of 
1> [CMake] the following names: 
1> [CMake] 
1> [CMake] wtConfig.cmake 
1> [CMake] wt-config.cmake 
1> [CMake] 
1> [CMake] Add the installation prefix of "wt" to CMAKE_PREFIX_PATH or set "wt_DIR" to 
1> [CMake] a directory containing one of the above files. If "wt" provides a separate 
1> [CMake] development package or SDK, be sure it has been installed. 
1> [CMake] Call Stack (most recent call first): 
1> [CMake] CMakeUsage/CMakeLists.txt:17 (find_package)
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

The usage test passed on x64-windows (header files found):

wt provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(wt CONFIG REQUIRED)
  target_link_libraries(main PRIVATE Wt::Wt Wt::HTTP Wt::Test Wt::Isapi)

@MonicaLiu0311 MonicaLiu0311 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Apr 9, 2024
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually want to restrict some features' supports?
Is this needed, or is this already covered by the dependencies' supports?

ports/wt/vcpkg.json Outdated Show resolved Hide resolved
ports/wt/vcpkg.json Outdated Show resolved Hide resolved
ports/wt/vcpkg.json Outdated Show resolved Hide resolved
@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Apr 10, 2024
ports/wt/0007-Wttest.patch Outdated Show resolved Hide resolved
ports/wt/portfile.cmake Outdated Show resolved Hide resolved
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review April 11, 2024 02:10
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Apr 11, 2024
@JavierMatosD JavierMatosD merged commit 5c12a3b into microsoft:master Apr 11, 2024
16 checks passed
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/fix_wt branch April 12, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants