Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[harfbuzz] add new CMake target and new feature #38182

Merged
merged 17 commits into from
Apr 18, 2024
Merged

[harfbuzz] add new CMake target and new feature #38182

merged 17 commits into from
Apr 18, 2024

Conversation

wyzdwdz
Copy link
Contributor

@wyzdwdz wyzdwdz commented Apr 14, 2024 •
edited

Fixes #38181.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Add new CMake target harfbuzz::harfbuzz-subset and new feature experimental-api

@wyzdwdz wyzdwdz marked this pull request as draft April 14, 2024 17:04
@wyzdwdz wyzdwdz changed the title [harfbuzz] add new feature: experimental-api [harfbuzz] add new CMake target: harfbuzz::harfbuzz-subset and new feature: experimental-api Apr 14, 2024
@wyzdwdz wyzdwdz changed the title [harfbuzz] add new CMake target: harfbuzz::harfbuzz-subset and new feature: experimental-api [harfbuzz] add new CMake target and new feature Apr 14, 2024
@wyzdwdz wyzdwdz marked this pull request as ready for review April 14, 2024 19:47
@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 15, 2024
JonLiu1993
JonLiu1993 reviewed Apr 15, 2024
View reviewed changes
ports/harfbuzz/usage Outdated Show resolved Hide resolved
wyzdwdz and others added 3 commits April 15, 2024 10:54
@wyzdwdz @JonLiu1993
Update ports/harfbuzz/harfbuzzConfig.cmake.in
7bbaf48 
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
@wyzdwdz @JonLiu1993
Update ports/harfbuzz/usage
7a36bfd 
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
@wyzdwdz
update version
d1b22f3
JonLiu1993
JonLiu1993 reviewed Apr 15, 2024
View reviewed changes
ports/harfbuzz/usage Outdated Show resolved Hide resolved
@wyzdwdz @JonLiu1993
Update ports/harfbuzz/usage
335e7a1 
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
@JonLiu1993
Copy link
Member

Feature experimental-api tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

Tested usage successfully by harfbuzz[experimental-api]:x64-windows:

The harfbuzz package provides CMake targets:

    find_package(harfbuzz CONFIG REQUIRED)
    target_link_libraries(main PRIVATE harfbuzz::harfbuzz harfbuzz::harfbuzz-subset)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 16, 2024
@JavierMatosD JavierMatosD merged commit 6c87aab into microsoft:master Apr 18, 2024
16 checks passed
@wyzdwdz wyzdwdz deleted the harfbuzz branch April 29, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[harfbuzz] Request feature "experimental_api"
3 participants
@wyzdwdz @JonLiu1993 @JavierMatosD