Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenVINO] Update to 2024.1.0 #38255

Merged
merged 2 commits into from
May 2, 2024
Merged

[OpenVINO] Update to 2024.1.0 #38255

merged 2 commits into from
May 2, 2024

Conversation

culhatsker
Copy link
Contributor

No description provided.

@culhatsker
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Intel"

@jimwang118 jimwang118 changed the title Add OpenVINO 2024.1.0 [OpenVINO] Update to 2024.1.0 Apr 19, 2024
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 19, 2024
@culhatsker culhatsker force-pushed the openvino20241 branch 3 times, most recently from 336618f to 6e6cdb3 Compare April 22, 2024 11:36
@culhatsker culhatsker force-pushed the openvino20241 branch 2 times, most recently from 12fe6b2 to 71bfa0b Compare April 22, 2024 13:22
@jimwang118
Copy link
Contributor

If you confirm the repair is complete, click "ready for review".

@culhatsker culhatsker marked this pull request as ready for review April 25, 2024 08:52
@jimwang118
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Apr 26, 2024
@culhatsker
Copy link
Contributor Author

@jimwang118, is there anything else we need to do to merge these changes?

JavierMatosD
JavierMatosD reviewed Apr 29, 2024
View reviewed changes
ports/openvino/vcpkg.json Outdated
Comment on lines 59 to 62
{
"name": "npu",
"platform": "x64 & !(osx | uwp) & !static"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be a default-feature? We typically only add stuff to the default-features if it is essentially required. See - https://learn.microsoft.com/en-us/vcpkg/concepts/default-features#role-of-default-features

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you're right, it is not essential, removed it from defaults

@JavierMatosD JavierMatosD marked this pull request as draft April 29, 2024 13:21
@culhatsker @ilya-lavrenov
Update ports/openvino/vcpkg.json
a2171b7 
Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
@culhatsker
Copy link
Contributor Author

x64_osx build failed with a few instances of this error:

pwsh(93825) MallocStackLogging: can't turn off malloc stack logging because it was not enabled.

But it seems to be an issue related to powershell, not this PR. Please correct me if I'm wrong.

@culhatsker culhatsker marked this pull request as ready for review April 30, 2024 16:09
@data-queue
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@data-queue data-queue merged commit b8a5f24 into microsoft:master May 2, 2024
17 checks passed
@culhatsker culhatsker deleted the openvino20241 branch May 3, 2024 08:59
yurybura pushed a commit to yurybura/vcpkg that referenced this pull request May 8, 2024
@culhatsker @ilya-lavrenov @yurybura
[OpenVINO] Update to 2024.1.0 (microsoft#38255)
2d32119 
<!-- If your PR fixes issues, please note that here by adding "Fixes
#NNNNNN." for each fixed issue on separate lines. -->

<!-- If you are still working on the PR, open it as a Draft:
https://github.blog/2019-02-14-introducing-draft-pull-requests/. -->

<!-- If this PR updates an existing port, please uncomment and fill out
this checklist:

- [ ] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] SHA512s are updated for each updated download.
- [ ] The "supports" clause reflects platforms that may be fixed by this
new version.
- [ ] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [ ] Any patches that are no longer applied are deleted from the port's
directory.
- [ ] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [ ] Only one version is added to each modified port's versions file.

END OF PORT UPDATE CHECKLIST (delete this line) -->

<!-- If this PR adds a new port, please uncomment and fill out this
checklist:

- [ ] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] The name of the port matches an existing name for this component
on https://repology.org/ if possible, and/or is strongly associated with
that component on search engines.
- [ ] Optional dependencies are resolved in exactly one way. For
example, if the component is built with CMake, all `find_package` calls
are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or
disabled with
[CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html).
- [ ] The versioning scheme in `vcpkg.json` matches what upstream says.
- [ ] The license declaration in `vcpkg.json` matches what upstream
says.
- [ ] The installed as the "copyright" file matches what upstream says.
- [ ] The source code of the component installed comes from an
authoritative source.
- [ ] The generated "usage text" is accurate. See
[adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md)
for context.
- [ ] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [ ] Only one version is in the new port's versions file.
- [ ] Only one version is added to each modified port's versions file.

END OF NEW PORT CHECKLIST (delete this line) -->

---------

Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JavierMatosD JavierMatosD JavierMatosD left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@artanokhov artanokhov artanokhov approved these changes

@data-queue data-queue data-queue approved these changes

Assignees

@jimwang118 jimwang118

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@culhatsker @jimwang118 @data-queue @ilya-lavrenov @JavierMatosD @artanokhov