Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functionalplus] Remove fplus, add functionalplus to instead of fplus. #38346

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

LilyWangLL
Copy link
Contributor

Closes #38213.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Apr 23, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Apr 24, 2024

Please fix commit and PR title: It is spelled fplus.

ports/functionalplus/portfile.cmake Outdated Show resolved Hide resolved
ports/functionalplus/portfile.cmake Outdated Show resolved Hide resolved
ports/functionalplus/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL changed the title [flus] Rename to functionalplus [functionalplus] Rename fplus to functionalplus Apr 24, 2024
@LilyWangLL LilyWangLL marked this pull request as ready for review April 24, 2024 09:10
Cheney-W
Cheney-W previously approved these changes Apr 24, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 24, 2024
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 24, 2024
@JavierMatosD
Copy link
Contributor

Please add a description to the new functionalPlus port mentioning that this is the new fplus port. That way if a user vcpkg search fplus then they will get the functionalPlus port.

Also, modify the frugallyDeep port to add the new functionalPlus port as a dependency.

Finally, remove fplus from the baseline and delete the port directory. Please leave the version files.

Thanks for the update! :)

@JavierMatosD JavierMatosD marked this pull request as draft April 25, 2024 22:30
@LilyWangLL LilyWangLL changed the title [functionalplus] Rename fplus to functionalplus [functionalplus] Remove fplus, add functionalplus to instead of fplus. Apr 26, 2024
@Cheney-W Cheney-W removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 26, 2024
@LilyWangLL LilyWangLL marked this pull request as ready for review April 28, 2024 01:21
@JavierMatosD JavierMatosD merged commit 9ff5229 into microsoft:master Apr 29, 2024
17 checks passed
@LilyWangLL LilyWangLL deleted the dev/LilyWang/rename_fplus branch May 29, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants