[mvfst] remove useless cmake #38473
Merged
[mvfst] remove useless cmake #38473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8ef
commented
Apr 30, 2024
| @@ -12,14 +12,6 @@ vcpkg_cmake_configure( | |||
| -DBUILD_TESTS=OFF | |||
| ) | |||
|
|
|||
| # Prefer installed config files | |||
| file(REMOVE | |||
| "${SOURCE_PATH}/fizz/cmake/FindGMock.cmake" | |||
There was a problem hiding this comment.
These lines were introduced two years ago, but they do not currently exist in the latest version of the repository.
There was a problem hiding this comment.
Are there any specific upstream instructions or commit? :)
There was a problem hiding this comment.
I actually don't know. I couldn't find the relevant file even in the oldest tag of this repository(https://github.com/facebook/mvfst/tree/v2023.07.24.00), so I believe this cleanup is fine.
There was a problem hiding this comment.
My personal guess is that this is a typo mistakenly added to the portfile, as I see the same lines in the fizz portfile.
https://github.com/microsoft/vcpkg/blob/master/ports/fizz/portfile.cmake#L14-L19
FrankXie05
requested changes
Apr 30, 2024
| @@ -12,14 +12,6 @@ vcpkg_cmake_configure( | |||
| -DBUILD_TESTS=OFF | |||
| ) | |||
|
|
|||
| # Prefer installed config files | |||
| file(REMOVE | |||
| "${SOURCE_PATH}/fizz/cmake/FindGMock.cmake" | |||
There was a problem hiding this comment.
Are there any specific upstream instructions or commit? :)
FrankXie05
added
the
category:code-cleanup
FrankXie05
approved these changes
Apr 30, 2024
yurybura
pushed a commit
to yurybura/vcpkg
that referenced
this pull request
May 8, 2024
<!-- If your PR fixes issues, please note that here by adding "Fixes #NNNNNN." for each fixed issue on separate lines. --> <!-- If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/. --> - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] SHA512s are updated for each updated download. - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [x] Any patches that are no longer applied are deleted from the port's directory. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. <!-- If this PR adds a new port, please uncomment and fill out this checklist: - [ ] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines. - [ ] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all `find_package` calls are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or disabled with [CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html). - [ ] The versioning scheme in `vcpkg.json` matches what upstream says. - [ ] The license declaration in `vcpkg.json` matches what upstream says. - [ ] The installed as the "copyright" file matches what upstream says. - [ ] The source code of the component installed comes from an authoritative source. - [ ] The generated "usage text" is accurate. See [adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md) for context. - [ ] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [ ] Only one version is in the new port's versions file. - [ ] Only one version is added to each modified port's versions file. END OF NEW PORT CHECKLIST (delete this line) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.