[FFmpeg] chromium patch #38683
[FFmpeg] chromium patch #38683
Conversation
| #endif | ||
|
|
||
| +// Chromium: We use the internal field first_dts vvv | ||
| +int64_t av_stream_get_first_dts(const AVStream *st) |
There was a problem hiding this comment.
Has this fix been synced upstream?
There was a problem hiding this comment.
No and it wont be. FFMPEG removed previously available API without giving a migration guide, so chromium struggles to remove the usage of this symbol. Please read the discussion in https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://issues.chromium.org/issues/40218408&ved=2ahUKEwjAiNSG5oSGAxVmc_EDHQCIC1IQFnoECA4QAQ&usg=AOvVaw0ZS9B5G7XW78802cwojWfv
There was a problem hiding this comment.
Where is this patch from? Has it been accepted in chromium or elsewhere?
There was a problem hiding this comment.
Original the patch was from https://aur.archlinux.org/cgit/aur.git/tree/040-ffmpeg-add-av_stream_get_first_dts-for-chromium.patch?h=ffmpeg-intel-full-git but I had to adjust it to the ffmpeg version vcpkg has.
After a bit of googling you can also find it here https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/95aab0fd83619408995720ce53d7a74790580220%5E%21/
However this also seems to be for a different ffmpeg version
I mean you can scan the chromium repo:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/ffmpeg/libavformat/avformat.h;l=1174
I moved the patch into mux_utils.c since the patch did not apply cleanly and I was looking for where av_stream_get_end_pts from the original patch went. At least it made sense for me to move it there. I can adjust the patch to move it back into utils.c but I don't think it makes any difference for the final library.
There was a problem hiding this comment.
also av_stream_get_end_pts compared to av_stream_get_first_dts felt kind of related by name.
jimwang118
added
the
category:port-feature
|
Compile test pass with following triplets: |
Required to build qtwebengine and probably chromium itself with ffmpeg on linux-dynamic