Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][qtinterfaceframework]Passing remove form fail list #38695

Closed
wants to merge 1 commit into from

Conversation

JonLiu1993
Copy link
Member

Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=102737&view=results

PASSING, REMOVE FROM FAIL LIST: qtinterfaceframework:x64-windows-static (D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
PASSING, REMOVE FROM FAIL LIST: qtinterfaceframework:x64-windows-static-md (D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt)

qtinterfaceframework:x64-windows-static=fail and qtinterfaceframework:x64-windows-static-md=fail were added to ci.baseline.txt by #38600, which has been fixed by #37923.
So remove

qtinterfaceframework:x64-windows-static=fail
qtinterfaceframework:x64-windows-static-md=fail
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels May 11, 2024
@Neumann-A
Copy link
Contributor

You also want to re add qt:x64-windows-static=pass however the problem itself is not yet fixed.

@JonLiu1993
Copy link
Member Author

You also want to re add qt:x64-windows-static=pass however the problem itself is not yet fixed.

It does not take effect currently in cibaseline. The CI test we have completed does not have this regression.

# qt:x64-windows-static=pass

@JonLiu1993 JonLiu1993 marked this pull request as ready for review May 11, 2024 09:44
@Neumann-A
Copy link
Contributor

The reason that has been commented was the failure of qtinterfaceframework ... It won't show up in CI unless you remove the # since it is a =pass line......

#38698 correctly reverts #38600 by simply pressing the revert button in the github UI of that PR

@data-queue data-queue closed this May 13, 2024
@JonLiu1993 JonLiu1993 deleted the dev/Jon/baseline branch May 14, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants