-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skia] update to 126 #38856
[skia] update to 126 #38856
Conversation
x64_uwp failure:
|
x64_windows failure:
|
Maybe we need a more recent version of ICU for skia. |
it seems that ICU 75.1 is out. |
I pushed an update to ICU as well to 75.1. |
It is not a problem with our icu. It is the problem of picking icu link libs from the windows SDK. This is what took so long to fix in the previous revision of skia. And for the icu update: you don't want to touch it now: #38826 |
I reverted the ICU change. |
I don't know where the icu problems come from. The build is using full filepaths for the icu libs, according to
I would probably manually "bisect" the changes since m124 in https://github.com/google/skia/commits/chrome/m126/modules/skunicode, limiting CI to x64-windows, and then study the changes at the failing commit. |
In addition, I spotted a bug in - set(libdirs_DEBUG "${CURRENT_INSTALLED_DIR}/lib/debug")
+ set(libdirs_DEBUG "${CURRENT_INSTALLED_DIR}/debug/lib") |
I can add that one. |
I may look into it in the future but we're currently in a rush with the 5.2 Beta of Bitwig Studio. |
./vcpkg x-add-version --all
and committing the result.