Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tinytiff] add new port #38874

Merged
merged 17 commits into from
May 31, 2024
Merged

[tinytiff] add new port #38874

merged 17 commits into from
May 31, 2024

Conversation

EfesX
Copy link
Contributor

@EfesX EfesX commented May 22, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

#38778
jkriege2/TinyTIFF#29

@EfesX EfesX marked this pull request as ready for review May 22, 2024 13:44
@jkriege2
Copy link

jkriege2/TinyTIFF#29 has been merged!

dg0yt
dg0yt reviewed May 22, 2024
View reviewed changes
ports/tinytiff/vcpkg.json Outdated Show resolved Hide resolved
ports/tinytiff/portfile.cmake Outdated Show resolved Hide resolved
ports/tinytiff/portfile.cmake Outdated Show resolved Hide resolved
ports/tinytiff/portfile.cmake Outdated Show resolved Hide resolved
ports/tinytiff/portfile.cmake Outdated Show resolved Hide resolved
ports/tinytiff/portfile.cmake Outdated Show resolved Hide resolved
ports/tinytiff/portfile.cmake Outdated Show resolved Hide resolved
ports/tinytiff/usage Outdated Show resolved Hide resolved
ports/tinytiff/msvc-message-support.patch Outdated Show resolved Hide resolved
EfesX and others added 4 commits May 23, 2024 00:26
@EfesX @dg0yt
Update ports/tinytiff/portfile.cmake
a660a88 
...handled by vcpkg_cmake_configure

Co-authored-by: Kai Pastor <dg0yt@darc.de>
@EfesX @dg0yt
Apply suggestions from code review
89e5fcf 
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@EfesX
edit patch
b51931d
@EfesX
update usage
a6e029e
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 23, 2024
FrankXie05
FrankXie05 requested changes May 23, 2024
View reviewed changes
ports/tinytiff/portfile.cmake Outdated Show resolved Hide resolved
EfesX and others added 2 commits May 23, 2024 16:19
@EfesX @FrankXie05
Update ports/tinytiff/portfile.cmake
c37ec1e 
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@EfesX
vcpkg x-add-version
ec8c359
@jkriege2
Copy link

I can make a Bugfix release!

@jkriege2
Copy link

THere you go: https://github.com/jkriege2/TinyTIFF/releases/tag/4.0.1.0

@EfesX
Copy link
Contributor Author

EfesX commented May 23, 2024

@jkriege2 Thanks!

@EfesX EfesX requested a review from FrankXie05 May 23, 2024 18:00
FrankXie05
FrankXie05 requested changes May 24, 2024
View reviewed changes
versions/t-/tinytiff.json Outdated Show resolved Hide resolved
EfesX and others added 2 commits May 24, 2024 20:19
@EfesX @FrankXie05
Update versions/t-/tinytiff.json
c2b5708 
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@EfesX
fix tinytiff.json
1f57ede
@EfesX EfesX requested a review from FrankXie05 May 25, 2024 05:34
FrankXie05
FrankXie05 previously approved these changes May 27, 2024
View reviewed changes
@FrankXie05 FrankXie05 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label May 27, 2024
@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels May 27, 2024
@FrankXie05
Copy link
Contributor

The usage has been tested successfully on x64-windows.

@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label May 27, 2024
sidy3d
sidy3d reviewed May 30, 2024
View reviewed changes
ports/tinytiff/vcpkg.json Outdated Show resolved Hide resolved
@vicroms vicroms removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label May 30, 2024
@vicroms vicroms merged commit fbd5bfd into microsoft:master May 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidy3d sidy3d sidy3d left review comments

@dg0yt dg0yt dg0yt left review comments

@vicroms vicroms vicroms approved these changes

@FrankXie05 FrankXie05 FrankXie05 left review comments

Assignees

@FrankXie05 FrankXie05

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@EfesX @jkriege2 @FrankXie05 @vicroms @sidy3d @dg0yt