Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg-make port #39050

Open
wants to merge 166 commits into
base: master
Choose a base branch
from
Open

vcpkg-make port #39050

wants to merge 166 commits into from
+2,136 −96

Conversation

JavierMatosD
Copy link
Contributor

@JavierMatosD JavierMatosD commented May 30, 2024 •
edited
Loading

Testing to see what happens when various options are on/off. Added a test port and cleaned up some of the code.

@Neumann-A
vcpkg-make initial idea
b499ded
@Neumann-A
don't run ci
62eb284
@Neumann-A
Make vcpkg portfile execution debugable
fffa564
@Neumann-A
WIP
2e1d32a
@Neumann-A
more WIP
36ce65c
@Neumann-A
install wrappers
23d3308
@Neumann-A
keep the configure_make somewhere for reference
92457bf
@Neumann-A
add function to warn about spaces
ab57ae7
@Neumann-A
strip whitespaces
7918e80
@Neumann-A
WIP
d3b8148
@Neumann-A
determine configure triplet
1f56817
@Neumann-A
wip
3ee0aa0
@Neumann-A
WIP
799b4c8
@Neumann-A
WIP . move more stuff over.
eaf0b67
@Neumann-A
WIP: create vcpkg_make_install
c0dc7d7
@Neumann-A
Merge remote-tracking branch 'upstream/master' into vcpkg-make
c5381ab
@Neumann-A
WIP code tuning
3933374
@Neumann-A
rename function to z_vcpkg_make_get_configure_triplets
3952202
@Neumann-A
Merge branch 'vcpkg-make' of https://github.com/Neumann-A/vcpkg into …
407d3f8 
…vcpkg-make

# Conflicts:
#	ports/vcpkg-make/vcpkg-make-common.cmake
#	ports/vcpkg-make/vcpkg-make.cmake
@Neumann-A
add configure cache
0b0df8d
@Neumann-A
More wip
facb152
@Neumann-A
fix includes
55ab880
@Neumann-A
fix automatic file include
fb6f0b0
@Neumann-A
make gmp use the new stuff
1bf57d6
@Neumann-A
fix stuff to configure (build flags are missing somehow)
a3621d3
@Neumann-A
more fixes
02dab22
@Neumann-A
cleanup message
f9fc193
@Neumann-A
remove "
06dd260
@Neumann-A
adjust tasks to test gmp
051adc4
@Neumann-A
move logfile analysis
5a181bf
@JavierMatosD JavierMatosD changed the title Testing vcpkg-make port vcpkg-make port Jun 20, 2024
@JavierMatosD
Copy link
Contributor Author

JavierMatosD commented Jul 1, 2024 •
edited
Loading

Automake needs updating for libidn2 to pass on android

@dg0yt
Copy link
Contributor

dg0yt commented Jul 1, 2024

Automake needs updating for libidn2 to pass on android

  1. I'm not convinced.
    It builds with vcpkg_configure_make now, in vcpkg CI and locally, with automake 1.16.1.
  2. "Automake needs updating" is broken in vcpkg because automake must come from the system in vcpkg. Up-to-date helper ports would already exist but are not accepted. E.g. [autoconf/automake/libtool] Add new port #9681.

What I do realize from the logs is that I introduced one bug in the patches.

@JavierMatosD JavierMatosD marked this pull request as ready for review July 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@Neumann-A Neumann-A Neumann-A left review comments

Assignees

@JonLiu1993 JonLiu1993

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JavierMatosD @Neumann-A @dg0yt @BillyONeal @JonLiu1993