Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libvpx] Add --disable-multithread option for libvpx #39399

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Joy1024
Copy link

@Joy1024 Joy1024 commented Jun 20, 2024

Add --disable-multithread option for libvpx

@WangWeiLin-MV WangWeiLin-MV added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 20, 2024
@Joy1024
Copy link
Author

Joy1024 commented Jun 20, 2024

@Joy1024 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@BillyONeal
Copy link
Member

BillyONeal commented Jun 21, 2024

Can you explain what this does and why this is a feature? See https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#features

In particular, it seems likely that someone might need to assert that this flag is not used, which means it can't be a feature.

@BillyONeal BillyONeal marked this pull request as draft June 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants