-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parsi] new port #39420
[parsi] new port #39420
Conversation
@@ -0,0 +1,17 @@ | |||
{ | |||
"name": "parsi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthulhu-irl, I can't find this port name when I search on Google. I have to add the repository "cthulhu-irl/parsi" to search. Do you mind changing its name to irl-parsi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's new, of course it won't be on google. I really prefer to keep the name. is there any way around that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
searches like parsi parser combinator
, parsi c++ library
, and parsi github
all seem to lead to my repo when I search (in private window).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it.
Putting the issue link here just to make these two (PR and issue) related: #39416 |
Tested usage successfully by
|
Tagging vcpkg-team-review for a second opinion on the name 'parsi'. It doesn't appear on Repology or in search results for 'parsi c++', but that search matches nothing else either, so I think confusion is unlikely, so I'm inclined to merge this as is. @cthulhu-irl Note that we would always accept the form 'github-org-name', in this case Thanks for the new port! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything about this looks good to me as long as other maintainers agree on the name. Thanks for the new port!
Thanks for the new port! |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.