Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parsi] new port #39420

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[parsi] new port #39420

merged 2 commits into from
Jun 27, 2024

Conversation

cthulhu-irl
Copy link
Contributor

@cthulhu-irl cthulhu-irl commented Jun 21, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 21, 2024
@@ -0,0 +1,17 @@
{
"name": "parsi",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthulhu-irl, I can't find this port name when I search on Google. I have to add the repository "cthulhu-irl/parsi" to search. Do you mind changing its name to irl-parsi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's new, of course it won't be on google. I really prefer to keep the name. is there any way around that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

searches like parsi parser combinator, parsi c++ library, and parsi github all seem to lead to my repo when I search (in private window).

Copy link
Member

@JonLiu1993 JonLiu1993 Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it.

@cthulhu-irl cthulhu-irl marked this pull request as ready for review June 21, 2024 07:15
@cthulhu-irl
Copy link
Contributor Author

Putting the issue link here just to make these two (PR and issue) related: #39416

@JonLiu1993
Copy link
Member

Tested usage successfully by parsi:x64-windows:

parsi provides CMake targets:

  find_package(parsi CONFIG REQUIRED)
  target_link_libraries(main PRIVATE parsi::parsi)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 21, 2024
@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Jun 21, 2024
@BillyONeal
Copy link
Member

Tagging vcpkg-team-review for a second opinion on the name 'parsi'.

It doesn't appear on Repology or in search results for 'parsi c++', but that search matches nothing else either, so I think confusion is unlikely, so I'm inclined to merge this as is.

@cthulhu-irl Note that we would always accept the form 'github-org-name', in this case cthulhu-irl-parsi.

Thanks for the new port!

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything about this looks good to me as long as other maintainers agree on the name. Thanks for the new port!

@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jun 27, 2024
@BillyONeal BillyONeal merged commit e3ad383 into microsoft:master Jun 27, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants