[ms-quic] Remove from ci.baseline.txt and fix UWP builds. #39498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix uwp builds so that all ci.baseline.txt entries can be removed, submitted upstream as microsoft/msquic#4373 Originally started from microsoft#39475 Co-authored by: Lily Wang <v-lilywang@microsoft.com>
BillyONeal
added
category:port-bug
BillyONeal
commented
Jun 24, 2024
| OPTIONS | ||
| ${FEATURE_OPTIONS} | ||
| -DQUIC_SOURCE_LINK=OFF | ||
| -DQUIC_TLS=openssl | ||
| -DQUIC_TLS_SECRETS_SUPPORT=ON |
There was a problem hiding this comment.
CMake Warning at installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:327 (message):
The following variables are not used in CMakeLists.txt:
QUIC_TLS_SECRETS_SUPPORT
Please recheck them and remove the unnecessary options from the
`vcpkg_cmake_configure` call.
If these options should still be passed for whatever reason, please use the
`MAYBE_UNUSED_VARIABLES` argument.Appears dead:
|
Note that upstream has comments on microsoft/msquic#4374 which broke some of their builds using the Visual Studio generators, but I think we should take this as-is because vcpkg always uses ninja and this turns on more testing. (Of course it should be changed to the actual change as accepted by upstream ASAP) |
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jun 25, 2024
As requested by upstream maintainer @nibanks in microsoft#39332 (review) This should probably be after microsoft#39498 makes CI test msquic for more targets.
7 tasks
JavierMatosD
approved these changes
Jun 25, 2024
|
Thanks for the initial fix @LilyWangLL ! Thanks for the review @JavierMatosD ! :) |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jun 26, 2024
[ms-quic] Remove from ci.baseline.txt and fix UWP builds. (microsoft#39498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix uwp builds so that all ci.baseline.txt entries can be removed, submitted upstream as microsoft/msquic#4373
Also fix x86-windows builds which incorrectly compared SYSTEM_PROCESSOR with 'win32' rather than 'x86'. Submitted upstream as microsoft/msquic#4374 . This patch originally authored by @LilyWangLL
Originally started from #39475
Co-authored by: Lily Wang v-lilywang@microsoft.com