Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANGLE] /guard:cf should be in linker flags as well #4172

Closed
birsoyo opened this issue Aug 27, 2018 · 0 comments · Fixed by #29861
Closed

[ANGLE] /guard:cf should be in linker flags as well #4172

birsoyo opened this issue Aug 27, 2018 · 0 comments · Fixed by #29861
Assignees
@PhoebeHui @Adela0814
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@birsoyo
Copy link

birsoyo commented Aug 27, 2018

While fixing Fix ANGLE on Windows, Linux, and MacOS, the /guard:cf flag removed from linker flags and added to compiler flags.

But according to /guard:cf msdn documentation, the flag should be passed to both compiler and linker.

msdn: The /guard:cf option must be passed to both the compiler and linker to build code that uses the CFG exploit mitigation technique
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 24, 2019
@PhoebeHui PhoebeHui self-assigned this Nov 27, 2019
Neumann-A added a commit to Neumann-A/vcpkg that referenced this issue Feb 25, 2023
@Neumann-A
[angle] close microsoft#4172
9ead86a
@Neumann-A Neumann-A mentioned this issue Feb 25, 2023
Merged
JavierMatosD pushed a commit that referenced this issue Feb 27, 2023
@Neumann-A
[angle] close #4172 (#29861)
dfd7a82 
* [angle] close #4172

* v db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhoebeHui PhoebeHui

@Adela0814 Adela0814

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[angle] close #4172 Neumann-A/vcpkg
4 participants
@birsoyo @PhoebeHui @NancyLi1013 @Adela0814